{AKS} Remove Unnecessary ContainerInsights Solution Addition since this being added in AKS RP #21173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganga1980
requested review from
andyliuliming,
jsntcy and
zhoxing-ms
as code owners
Collaborator
|
AKS |
Member
|
@ganga1980， |
Contributor
Author
|
wangzelin007
changed the title
Contributor
Author
|
hi, @wangzelin007, @FumingZhang , can you please review this PR? |
wangzelin007
approved these changes
Feb 11, 2022
zhoxing-ms
approved these changes
Feb 11, 2022
FumingZhang
approved these changes
Feb 11, 2022
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM
BTW, we have the same code in aks-preview. Could you please help remove the deployment for csi in that repo?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Container Insights Solution being added (if it doesnt exist already) by the AKS RP as part of the monitoring addon enablement. This PR removes this unnecessary ContainerInsights solution addition.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.